search

kroxylicious / kroxylicious-junit5-extension

JUnit5 extension and helpers for writing tests parameterised over Kafka clusters
Apache License 2.0
9 stars 10 forks source link

Remove some unnecessary defaults and make a couple of tidy up after the SASL work. #340

Closed k-wall closed 3 months ago

k-wall commented 4 months ago

Type of change

Select the type of your PR

Description

Remove some unnecessary defaults and a couple of tidy up after the SASL work.

I was expecting to require a few more changes to enable SASL OAuth through the extensions. It turned out not to be case. I made a couple of tidy ups on the way to discovering that, resulting in this PR.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

k-wall commented 4 months ago

I'm drafting out an intergration test in Kroxylicious to verify the use-case.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud