Bump kafka.version from 3.7.0 to 3.7.1

dependabot[bot] commented 4 months ago

Bumps kafka.version from 3.7.0 to 3.7.1. Updates org.apache.kafka:kafka-clients from 3.7.0 to 3.7.1

Updates org.apache.kafka:kafka_2.13 from 3.7.0 to 3.7.1

Updates org.apache.kafka:kafka-server-common from 3.7.0 to 3.7.1

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @k-wall.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

k-wall commented 4 months ago

I think this'll need some reflective code. Annoying!

SamBarker commented 3 months ago

I think this'll need some reflective code. Annoying!

@k-wall care to shed some light on that comment?

I only saw it as I was coming to ping you about the failure. It seems to be related to creating users in zookeeper but I haven't got deeper than that. Nothing in the Kafka Release notes sounds related...

SamBarker commented 3 months ago

Ok I figured the reflection bit out.

The problem comes from https://issues.apache.org/jira/browse/KAFKA-16539 which was implemented in https://github.com/apache/kafka/commit/b124aa48f295106c5f9267f5c4cf81c7ba93fa18 specifically https://github.com/apache/kafka/blob/b124aa48f295106c5f9267f5c4cf81c7ba93fa18/core/src/main/scala/kafka/server/KafkaApis.scala#L2976-L2980 which now fails for us as we are operating without an active Kafka controller.

I've opened https://github.com/kroxylicious/kroxylicious-junit5-extension/pull/353 against this PR as I haven't resolved the issues with error handling around the reflection failures but wanted to canvas opinion on the fix.

SamBarker commented 3 months ago

now failing because there is no Kafka-native 3.7.1 image. Whats the right call for that? Do we wait for a release there or do we make sure we load the 3.7.0 image for this PR?

@k-wall ?

k-wall commented 3 months ago

now failing because there is no Kafka-native 3.7.1 image. Whats the right call for that? Do we wait for a release there or do we make sure we load the 3.7.0 image for this PR?

@k-wall ?

I'll do a release of kafka_native.

k-wall commented 3 months ago

@dependabot merge