search

kroxylicious / kroxylicious-junit5-extension

JUnit5 extension and helpers for writing tests parameterised over Kafka clusters
Apache License 2.0
9 stars 10 forks source link

TopicConfig annotation name clash #351

Open fvaleri opened 4 months ago

fvaleri commented 4 months ago

This is a bit ugly:

@Test
public void shouldAlterConfigs(KafkaCluster cluster,
                               @io.kroxylicious.testing.kafka.junit5ext.TopicConfig(name = TopicConfig.RETENTION_MS_CONFIG, value = "604800000") Topic t1,
                               @io.kroxylicious.testing.kafka.junit5ext.TopicConfig(name = TopicConfig.CLEANUP_POLICY_CONFIG, value = "delete") Topic t2) {
...

Maybe we can deprecate this annotation and rename to avoid the name clash with Kafka.