kroxylicious / kroxylicious-junit5-extension

JUnit5 extension and helpers for writing tests parameterised over Kafka clusters
Apache License 2.0
9 stars 10 forks source link

Bump kafka.version from 3.8.0 to 3.9.0 #417

Closed dependabot[bot] closed 1 week ago

dependabot[bot] commented 2 weeks ago

Changes to support Kafka 3.9 made in a backwardly compatible fashion.

Reflection is used so that, at runtime, the user of the Extension may provide an alternative (earlier) version of Kafka on the classpath. You can show this using these commands (we ought to add this to a CI matrix).

mvn package -DskipTests
mvn verify -Dtest=KafkaClusterTest -Dkafka.version=3.7.0 -Dmaven.javadoc.skip=true  -Dsurefire.failIfNoSpecifiedTests=false

The new tests in KafkaClusterTest test the ability to connect to the controllers' endpoint. This currently supports only the IN_VM use-case. Supporting CONTAINER requires a deeper change (controller ports need to be exposed to the host whilst maintaining the ability of the brokers to dial the controllers within the Docker network), so I'd rather do this as a separate PR. I'd like to get feedback on this PR and merge before going further.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
67.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud