kroxylicious / kroxylicious-junit5-extension

JUnit5 extension and helpers for writing tests parameterised over Kafka clusters
Apache License 2.0
9 stars 10 forks source link

Make the reflective invocations a little more generic #422

Closed SamBarker closed 1 week ago

SamBarker commented 1 week ago

Type of change

Description

Code cleanup around the use of reflection when preparing log dirs

Additional Context

I felt there was a lot of boilerplate code prepareLogDirsForKraftKafka39Plus which obscured what as actually being done. I thought it was possible to simplify things a bit by extracting a method but things got a bit more complicated.

So I'm not convinced this makes things easier to read or not and even if it does is it worth the extra code? I thought it was easier to have that discussion on an additional PR than as comments on the original. I'm happy to drop and delete this if thats the consensus.

Checklist

Please go through this checklist and make sure all applicable tasks have been done