Try and associate a pull policy when we know its a floating tag.

kroxylicious / kroxylicious-junit5-extension

JUnit5 extension and helpers for writing tests parameterised over Kafka clusters

Apache License 2.0

9 stars 10 forks source link

Try and associate a pull policy when we know its a floating tag. #423

Open SamBarker opened 1 week ago

SamBarker commented 1 week ago

Type of change

Bugfix

Description

Fixes #421

Additional Context

We should default to pull always when we know we are specifying a floating tag.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

k-wall commented 5 days ago

I verified that with your refactoring on this PR, KAFKA_IMAGE_REPO/KAFKA_IMAGE_TAG env vars can still be used to direct TestContainersKafkaCluster to an alternative image registry/organisation.

k-wall commented 4 days ago

Did you rebase already? If you haven't container base tests will fail against the new images because the Kafka configuration will be wrong.

sonarcloud[bot] commented 4 days ago

Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

SamBarker commented 4 days ago

Quality Gate failed

Failed conditions
1 Security Hotspot

It doesn't like the regex. I need to have another go at simplifying it or its usage.

0.0% Coverage on New Code (required ≥ 80%)

Errr I wrote tests. What's happening to coverage??? A question for Monday