kroxylicious / kroxylicious.github.io

kroxylicious.io org page
0 stars 8 forks source link

Fixes for GitHub Actions workflow and development work #14

Closed gracegrimwood closed 8 months ago

gracegrimwood commented 8 months ago

Update workflow to use jekyll instead of github-pages gem, fix docs link for places not using the kroxylicious domain.

We are currently using a GitHub Action that is pulling in the github-pages gem instead of the Jekyll one, so this PR fixes that by using the Jekyll-recommended workflow (rather than the GitHub-recommended one) which installs and sets everything up manually.

There was also a problem with using absolute_url for the docs link when rendering the site on any domain that wasn't kroxylicious.io, where it would append the path incorrectly (this was only a problem for /docs because it's not rendered by Jekyll). Using the relative_url filter for this link should fix this for people who want to test their changes under their own GitHub account, while still retaining functionality on the main site.