search

krpc / krpc2

Remote Procedure Calls for Kerbal Space Program 2
Other
46 stars 3 forks source link

Update .gitignore #3

Closed GaryDeco closed 1 year ago

GaryDeco commented 1 year ago
djungelorm commented 1 year ago

Could you also delete the lib/ksp2 symlink from the repository?

GaryDeco commented 1 year ago

Could you also delete the lib/ksp2 symlink from the repository?

I did this with the idea that you would place your symlink within a ksp2 folder and the contents would be ignored so symlinks were not uploaded to repo. If there needs to be a bazel BUILD script within the folder or something I can just ignore KSP_x64_Data? But this ignores the whole thing. so can make it lib/ksp2/

djungelorm commented 1 year ago

Could you also delete the lib/ksp2 symlink from the repository?

I did this with the idea that you would place your symlink within a ksp2 folder and the contents would be ignored so symlinks were not uploaded to repo. If there needs to be a bazel BUILD script within the folder or something I can just ignore KSP_x64_Data? But this ignores the whole thing. so can make it lib/ksp2/

You can't have an empty directory in a git repository. The broken symlink still exists in the repository, and we should at least remove that.

GaryDeco commented 1 year ago

What I would do is have a folder called ksp2 with a dummy file KSP_DIRECTORY_HERE or whatever and use the folder for the external dlls. ignore the contents of the folder so each build is clean.

djungelorm commented 1 year ago

Yeah I like that idea. Maybe call the file README.txt though?

GaryDeco commented 1 year ago

Sure. Arbitrary name. That works too!

Get Outlook for iOShttps://aka.ms/o0ukef

From: djungelorm @.> Sent: Monday, March 20, 2023 9:02:16 PM To: krpc/krpc2 @.> Cc: Gary @.>; Author @.> Subject: Re: [krpc/krpc2] Update .gitignore (PR #3)

Yeah I like that idea. Maybe call the file README.txt though?

— Reply to this email directly, view it on GitHubhttps://github.com/krpc/krpc2/pull/3#issuecomment-1477144767, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIOLF2M4MB6MKPIOGJ3LVA3W5D4ZRANCNFSM6AAAAAAWBY27LQ. You are receiving this because you authored the thread.Message ID: @.***>

GaryDeco commented 1 year ago

I will be more careful with that moving forward. Adding issue for pull request and issue templates to mirror kRPC.