search

krrish1008 / tortoisesvn

Automatically exported from code.google.com/p/tortoisesvn
0 stars 0 forks source link

externals property not correctly converted to a relative url #635

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported on the mailing list:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30768
79

This problem is similar to 
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=30766
63 
but is a little bit different and is only related to the Repository browser in 
External dialog.

Description:
If the main repository is located at "REPOSITORY_URL/SOMEPATH" then the 
repository browser in "Externals" dialog treats url like 
"REPOSITORY_URL/SOMEPATHfoobar" as a local path in the same repository and not 
as a different repository.

I installed some toy repos to illustrate the bug.
Steps to reproduce:
1. Using TortoiseSVN do a local checkout of the following repository url: 
https://xp-dev.com/svn/myproject678

2. Right-click the checkout folder, go to "TortoiseSVN -> Properties".

3. Select "svn:externals" line, click "Edit..." You'll see two external folders:
fromvendor -> https://xp-dev.com/svn/myproject678_vendor
fromab -> https://xp-dev.com/svn/myproject678ab
( http://imagizer.imageshack.us/a/img845/1843/u47z.jpg )

4. Do not close the dialog, select "fromab" external and click "Edit...". Now 
you can change the url for the external:
( http://imagizer.imageshack.us/a/img836/3694/4j5z.jpg )

5. Click "..." near the URL field. A repository browser appears that correctly 
detects the repository url: https://xp-dev.com/svn/myproject678ab
( http://imagizer.imageshack.us/a/img842/7025/e94v.jpg )

6. Do not change anything, simply Click "OK" in a repository browser.

EXPECTED: URL of an External repository is NOT changed

ACHIEVED: URL is changed to  ^/ab
( http://imagizer.imageshack.us/a/img842/5151/v92g.jpg )

So the repo browser started at url https://xp-dev.com/svn/myproject678ab but 
after clicking OK it changed it to ^/ab

---------------
Notes:

If you save this changes and try to do svn-update then naturally you get an 
error: 
Error: URL 'https://xp-dev.com/svn/myproject678/ab' at revision 6 doesn't exist 

It seems to me there is an error somewhere in regexp that should detect local 
repository and instead of treating "REPOSITORY_URL/subdir" as local repo it 
treats "REPOSITORY_URLsubdir" as a local repo.

Original issue reported on code.google.com by tortoisesvn on 23 Apr 2014 at 6:03

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r25443.

Original comment by tortoisesvn on 23 Apr 2014 at 6:47

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r25445.

Original comment by tortoisesvn on 23 Apr 2014 at 8:24