search

krrish94 / chamferdist

Pytorch package to compute Chamfer distance between point sets (pointclouds).
Other
290 stars 50 forks source link

Torch dependency #12

Open cdicle-motional opened 3 years ago

cdicle-motional commented 3 years ago

@krrish94 Your package depends on the torch library but it is not listed in setup.py. Can you add that dependency to your setup.py?

krrish94 commented 3 years ago

@cdicle-nutonomy This is an intentional omission -- the reason being everyone prefers using a different version of pytorch (based on their python/conda/pip/cuda configs)

krrish94 commented 3 years ago

Your point is well-taken though. We'll improve our messaging in the README to better articulate this pytorch dependency

cdicle-motional commented 3 years ago

@krrish94 I think you can put something like

setup(
    ...
    install_requires=[
        ...
        'torch ~= 1.0 ;',
        ...
    ],
    ...
)

which should cover practically all torch versions but at least inform pip that the package depends on torch.

krrish94 commented 3 years ago

This is a great point

GordonGustafson commented 3 years ago

Since the setup.py file currently requires torch, I don't think adding install_requires to setup.py will fix the issue, as the setup.py can't even be run until torch is installed.

The ideal solution is for wheels to be published to pypi, so the package can be installed without running setup.py. @krrish94 do you think that would be possible?