krrish94 / nerf-pytorch

A PyTorch re-implementation of Neural Radiance Fields
Other
884 stars 121 forks source link

another small bug #28

Open OshriHalimi opened 3 years ago

OshriHalimi commented 3 years ago

https://github.com/krrish94/nerf-pytorch/blob/a14357da6cada433d28bf11a45c7bcaace76c06e/nerf/train_utils.py#L176

This function is called also in validation mode, but then, since the variable "mode" is not passed as an argument, the function is called with the default 'train' value.

Wuao652 commented 2 years ago

The same problem! Previous implementation will result in a "noisy" output where there will be some "dots" appearing in the scene.