krrish94 / nerf-pytorch

A PyTorch re-implementation of Neural Radiance Fields
Other
884 stars 121 forks source link

Skip connection inconsistency and `AttributeError: 'FlexibleNeRFModel' object has no attribute 'linear_layers'` #40

Open BjoernHaefner opened 1 year ago

BjoernHaefner commented 1 year ago

I guess in this line, linear_layers should be layers_xyz?

In a similar realm, I guess in this line you don't want a skip connection in the last layer? Then i != num_layers - 1 should be i != num_layers - 2, as the for-loop is in range(num_layers - 1) already? i will never be num_layers - 1, so it could happen that you have a skip-connection in the last layer of layers_xyz, e.g. if skip_connect_every=4 and num_layers=10. This should then throw an error in the forward call in this line. As there would be a dimension mismatch.