search

krrishnarraj / clpeak

A tool which profiles OpenCL devices to find their peak capacities
Apache License 2.0
396 stars 111 forks source link

Use FindOpenCL rather than custom OpenCL finders #45

Closed hjmallon closed 5 years ago

hjmallon commented 6 years ago

This change messes with the CMake file to use the built-in FindOpenCL.cmake. This should mean that as more OpenCL SDKs are integrated into the upstream CMake file clpeak will be able to detect them.

I understand that you might not want to mess with something that currently works but doing this helped me to bring up clpeak with a different OpenCL implementation.

krrishnarraj commented 6 years ago

Since it requires cmake 3.1, which is present only from ubuntu 16.04, I was holding it for some time. Now it makes sense to move to cmake script.

If someone can confirm if it works on mac, I will finish windows & linux testing and merge it

hjmallon commented 6 years ago

I have been testing mainly on macOS (latest CMake). It works for me. We have fairly recent cmake floating around all our Windows/Linux/Mac machines here due to recent features and bug fixes that we need for our in house stuff.