krritik / nest4guest

This is a python based online guest house booking system

13 stars 13 forks source link

Closed Sahilbabani closed 4 years ago

Sahilbabani commented 4 years ago

Pull request checklist

[ ] I have performed a self-review of my own code
[ ] I have deployed locally to see if issue is fixed
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] Assigned current issues or new issues to PR -[ ]login and signup page footer alignment changed -[ ]image added in home page -[ ] topnav added

krritik commented 4 years ago

I will review this tomorrow. Since you have added bootstraps file in this too. So no need to merge your previous PR.

krritik commented 4 years ago

Is this a WIP(work in progress) PR or a complete PR And there are also some merge confilcts, resolve them.

Sahilbabani commented 4 years ago

its is in wip pr

Sahilbabani commented 4 years ago

Are those conflicts resolved?

krritik commented 4 years ago

No, but you can do it later(not necessary now), just make sure to resolve conflicts before final PR. And also remind me, when PR is ready to merge.

Sahilbabani commented 4 years ago

I would like change layout of staff_login page

krritik commented 4 years ago

You can work on that too, but I cannot assign two issues at the same time. If you want to do that first, you are free to do it.