Frontend Design

[Suchana34]

Pull request checklist

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have deployed locally to see if issue is fixed
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] Assigned current issues or new issues to PR

[Rits1272]

I guess, you should close PR #36

[Suchana34]

I guess, you should close PR #36

Okay, thanks.

[Suchana34]

I have edited most of the frontend, but still few changes are left, like the login form, change password form, and responsive design. I will continue working on it, just review the design I gave.

[krritik]

Till now, it looks cool. I actually loved it. :heart_eyes: A few suggestions, "the size of start date and end date are very small" and there are also some other minute changes possible(sizes of context, the date should be in the middle of the search box) You can also improve this table.

Since you are not complete with the design, I would wait for your completion. So when you are done, Ping me.

[Rits1272]

Design is actually quite good :)

[Suchana34]

Thank you @krritik @Rits1272 :) I have noted the suggestions and soon work on it.

[Suchana34]

I have redesigned the tables and made the pages responsive.

[Suchana34]

Please review @krritik .

[Suchana34]

[Suchana34]

[Suchana34]

[Suchana34]

[krritik]

cool It looks good I will review it asap But I have some urgent work till 27 so there might be some delay in merging PR

[Suchana34]

Okay, sure.

[Suchana34]

Hello @krritik since 2nd Jan is the last day of pr, let me know before 30th what further changes I need to do.

[krritik]

Staff login is still the old, you can create an issue for it and later work on it. So that I can merge this without even updating staff login or otherwise improve its layout too.

The font size of a few things like Username, Email are still very small, can increase the size of them a bit.(At some other places too, the font size is a bit smaller).

You can change the color of the "Edit" button, but it is not a much problem(just recommendation).

[krritik]

@Suchana34 Do the necessary changes and I will try to merge it asap. Just ping me once in slack, when you have done this.

[Suchana34]

Hello @krritik, I have fixed the size of the text of the forms. Since I didn't know much about Django Form widgets then, so I couldn't modify them earlier, now it is solved :) I also edited the error messages.

[Suchana34]

And I will create an issue now for the staff side and work on it soon.

[Suchana34]

[Suchana34]

[krritik]

looks fine for now also always assign the issue to PR. It helps in future.

[krritik]

solved issue #5