search

krritik / nest4guest

This is a python based online guest house booking system
13 stars 13 forks source link

Improve layout for the app #5

Open krritik opened 4 years ago

krritik commented 4 years ago

Currently the frontend is written only in css and html and is very basic. So improve the layout and add features like "Adjusting your websites to fit all types of resolution" and "navigation bar"

Sahilbabani commented 4 years ago

i woulld love to do improve layout. please assign it to me.

krritik commented 4 years ago

Cool, You can take the issue. But assigning means others will not be able to work on it. I can assign you, once you start working on it and have a WIP( work in progress ) pr and comment here a proposed solution.

Sahilbabani commented 4 years ago

addning bootstrap files for responsive website and future implementation

krritik commented 4 years ago

ok, I will assign you after a few more commits and do not worry, I will not assign it to anyone else. So work on it.

Sahilbabani commented 4 years ago

thanks

Sahilbabani commented 4 years ago

layout of home,login,signup page improved in pr-25

Sahilbabani commented 4 years ago

pr #25

krritik commented 4 years ago

@Sahilbabani is it complete?

Sahilbabani commented 4 years ago

Home page , login and sign-up page done

On Tue, 10 Dec, 2019, 10:40 PM Ritik Kumar, notifications@github.com wrote:

@Sahilbabani https://github.com/Sahilbabani is it complete?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/krritik/nest4guest/issues/5?email_source=notifications&email_token=AK5FEVX7C6JCEETSZ4KJSYLQX7ESFA5CNFSM4JS5S72KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGQAI5Q#issuecomment-564135030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5FEVVADV5BGWNFEEXMXI3QX7ESFANCNFSM4JS5S72A .

Sahilbabani commented 4 years ago

[] -User ,home,booking pages layput improved [] -footer position corrected and added data in it in pr #25

krritik commented 4 years ago

Few changes are done, there is still a lot of scope for improvement like refactor of code (currently the header-footer code is written in all Html files, which can be created as separated template and just can be called in every template), still, it looks a lot of plain text. So, you can add any changes to improvement. If you have any doubts, comment here your ideas and queries

krritik commented 4 years ago

I unassigned this, So now this is open for all to work.

Suchana34 commented 4 years ago

I am working on it. It is getting delayed due to my exams.

krritik commented 4 years ago

Sure, you can send a working PR and a deadlinr for it

Suchana34 commented 4 years ago

I have completed almost. Some changes are left.