krschultz / android-proguard-snippets

Proguard configurations for common Android libraries
http://www.kevinrschultz.com/blog/2014/02/15/proguard-with-gradle/
Apache License 2.0
4.59k stars 598 forks source link

Add Timber 4.0.1 #75

Closed BillZangardi closed 8 years ago

BillZangardi commented 8 years ago

https://github.com/JakeWharton/timber

Flydiverny commented 8 years ago

Timber shouldn't require any additional proguard rules?

And for required proguard rules it contains a consumer-proguard-rules.pro (link) already including the necessary rules for you :)

Timber proguard: -dontwarn org.jetbrains.annotations.**

Update: The consumer-proguard-rules.pro in timber was added in 4.1.0, my bad :) So updating to 4.1.0 should solve the problem otherwise add the snippet above.

krschultz commented 8 years ago

Thanks @Flydiverny, that's really helpful. I think I'm going to close this, whenever a library has consumerProguard files that is the preferred solution. Although it requires an upgrade from 4.0.1 to 4.1.0 that doesn't look too onerous.