search

krtek4 / MultiPass

Automatically login to Basic Authentication using data based on URL regexp.
http://gilles.crettenand.info/MultiPass
Do What The F*ck You Want To Public License
88 stars 23 forks source link

Issue with GUI using long regex #52

Closed joachimtingvold closed 7 years ago

joachimtingvold commented 7 years ago

Hi,

Having long regex-matches seems to "break" the GUI; the width of the "dropdown" window is smaller than the width of the content, causing things to get out of scope, and without any scrollbars.

Going to the full-page option page, things are still out of scope, but it's possible to at least scroll sideways.

joachimtingvold commented 7 years ago

dump_2017-06-06_11 14 11 dump_2017-06-06_11 14 33

krtek4 commented 7 years ago

Thanks for the screenshot, I was going to ask one :)

The fix should be pretty straightforward, I plan to limit the width of the column and display an ellipsis to indicate that the regex is actually longer and display it on hover. Would that suits you ?

joachimtingvold commented 7 years ago

For showing them; sure. How about editing when you are in the "Popin" window?

krtek4 commented 7 years ago

Hey, had a pretty eventful week, so the fix is coming rather later than sooner.

I put the ellipsis in place, and when you hover the cell, the full content should be displayed as it is also now put as the title of the cell.

Concerning the edition, I don't have a "good" solution. It is possible to edit it as the input box allows to have longer text, but I agree it is not ideal. Do you have any idea ?

krtek4 commented 7 years ago

The fix is available in the latest release : https://github.com/krtek4/MultiPass/releases/tag/v0.7.3

I'll publish it after some more test

joachimtingvold commented 7 years ago

Hi,

Thanks. Seems to be working so far on my end. I don't think it's necessary to do anything more regarding editing long regexes. Sure, it's a bit cumbersome with a "horisontal scrolling" text input field, but you can just copy/paste stuff, and edit it somewhere else.

krtek4 commented 7 years ago

Just released on the three addon stores, update should be automatically applied shortly. I am closing this on the meantime :)