krtschmr / monero

Ruby client to connect to the Monero RPC

MIT License

24 stars 12 forks source link

Add RPC::Client.new #16

Closed xaviablaza closed 5 years ago

xaviablaza commented 5 years ago

Description

Add RPC::Client.new(host, port, username, password, transfer_clazz, rpc, debug)

GitHub Issue

15

Pull Request Changes

Add attr_reader to RPC::Client
Add uri method to RPC::Client

krtschmr commented 5 years ago

@langesi can you check if you can find anything that seems wrong?

krtschmr commented 5 years ago

i wonder if anybody else can say something to this branch and if it's a good idea. development needs to go on, but i don't want to be the central guy who needs to decide things.

xaviablaza commented 5 years ago

@krtschmr Removed .tool-versions and squashed all commits into 1.

xaviablaza commented 5 years ago

Can we safely merge in now?

krtschmr commented 5 years ago

Will do when I’m back from holiday

krtschmr commented 5 years ago

i just tried this out, isn't even working. docs are broken with this. whats going on? :dango:

xaviablaza commented 5 years ago

Will double check.

On Wed, Jul 31, 2019, 18:34 Tim Kretschmer notifications@github.com wrote:

i just tried this out, isn't even working. docs are broken with this. whats going on? 🍡

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/krtschmr/monero/pull/16?email_source=notifications&email_token=AGBUBFVVXHCXYJQTHP4MNODQCI4SXA5CNFSM4HI43DL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3JA64A#issuecomment-517082992, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBUBFQY7F4OZBYZAPE2RVTQCI4SXANCNFSM4HI43DLQ .

krtschmr commented 5 years ago

https://github.com/krtschmr/monero/tree/refactoring

check this. that's how to do it

krtschmr commented 5 years ago

i merged already and pushed to rubygems for version 0.0.12

please have a look. test are passing.