krtschmr / monero

Ruby client to connect to the Monero RPC
MIT License
24 stars 12 forks source link

Revert "Add RPC::Client.new" #18

Closed krtschmr closed 5 years ago

krtschmr commented 5 years ago

tests failing, all functionality is failing anyways

Reverts krtschmr/monero#16

xaviablaza commented 5 years ago

I'm curious about the tests failing. You would need to configure the RPC in spec_helper.rb to point to your node, otherwise all the tests would fail anyway.

I'm thinking of building the tests around a FakeMoneroRPC to imitate the actual behavior of the RPC without hitting the RPC itself. Will submit another PR with these changes.