search

krtschmr / monero

Ruby client to connect to the Monero RPC
MIT License
24 stars 12 forks source link

Fix: NoMethodError (undefined method `confirmations=' for #<RPC::IncomingTransfer... #8

Closed langesi closed 5 years ago

langesi commented 5 years ago

Hi, I have an update. There was an error caused by 0.13, so the new Monero version.

The new monero version now includes "confirmations" and "suggested_confirmations_threshold". Both have been added to the module class "IncomingTransfer".

Methods "confirmed?" and "pending?" checked are still working, as they should.

krtschmr commented 5 years ago

Hello @langesi , thanks for your contribution. I had no time at all to have a look at 0.13.

if confirmations is coming from the TX itself, then we don't need it and can remove it. nice!

krtschmr commented 5 years ago

@langesi you should be able to accept merge requests yourself