Added support for additional units for the metric values

kruize / autotune

Autonomous Performance Tuning for Kubernetes!

Apache License 2.0

164 stars 54 forks source link

Added support for additional units for the metric values #1038

Closed shekhar316 closed 11 months ago

shekhar316 commented 1 year ago

This PR solves Issue https://github.com/kruize/autotune/issues/1036

Currently Kruize supports only MiB unit for the metric values. We added support for different memory units like Bytes, KiB, MiB, GiB, TiB, PiB, EiB

dinogun commented 11 months ago

@shekhar316 we could have bytes as well (All lower case)

shekhar316 commented 11 months ago

@shekhar316 we could have bytes as well (All lower case)

Hi @dinogun,

Added the 'bytes' all lowercase.

dinogun commented 11 months ago

@shekhar316 Please dont use force push for your commits, it's not a good practice as it is difficult to look at what changed between commits.

dinogun commented 11 months ago

@chandrams what tests need to be added / changed to now support the Bytes format?

shekhar316 commented 11 months ago

@shekhar316 Please dont use force push for your commits, it's not a good practice as it is difficult to look at what changed between commits.

Sure, will keep in mind from next time ...

chandrams commented 11 months ago

@dinogun - The results json used in the tests at present have format as MiB with some dummy metrics values, we can change the memory format with the same value to the supported formats and test it.

Recommendation infra uses real data metrics we can update the scripts there as well to test the actual recommendations with these supported formats.