search

kruize / autotune

Autonomous Performance Tuning for Kubernetes!
Apache License 2.0
158 stars 54 forks source link

Updated to trigger a notification if CPU recommendations are unavailable at profile level. #1156

Closed msvinaykumar closed 5 months ago

msvinaykumar commented 5 months ago

Updated to trigger a notification if CPU recommendations are unavailable at profile level.

following notifications are missed

"CPU Usage is less than a millicore, No CPU Recommendations can be generated" "CPU usage is zero, No CPU Recommendations can be generated"

chandrams commented 5 months ago

@msvinaykumar - Can you please update the function test suite with tests to ensure such regressions are not missed out. You can refer this issue to check for tests added for which notifications. Thank you.

msvinaykumar commented 5 months ago

@msvinaykumar - Can you please update the function test suite with tests to ensure such regressions are not missed out. You can refer this issue to check for tests added for which notifications. Thank you.

@chandrams was there any previously written test cases check for CPU usage being zero or less than a millicore. Or Do I need to include new test cases?

chandrams commented 5 months ago

@msvinaykumar - Tests for these notifications aren't present in the testsuite, new tests are required. You can check the issue above to see for which notification codes tests were added earlier.

msvinaykumar commented 5 months ago

@msvinaykumar - Tests for these notifications aren't present in the testsuite, new tests are required. You can check the issue above to see for which notification codes tests were added earlier.

done