search

kruize / kruize-ui

Kruize Autotune UI
MIT License
6 stars 12 forks source link

Notifications at cost and perf levels #175

Closed bhanvimenghani closed 5 months ago

bhanvimenghani commented 6 months ago

This pr adds alerts for over and under resource utilization in the UI. This pr has been made as per the json structure shared here. A demo video reflecting the changes is attached here

bhanvimenghani commented 5 months ago

@dinogun quay.io/bmenghan/notifications image with the pr changes.

bhanvimenghani commented 5 months ago

Fixed conflicts

kusumachalasani commented 5 months ago

As discussed, we should be able to view all the notifications related to one recommendation at a time.

bhanvimenghani commented 5 months ago

here is the updated view of the ui with before (in perf tab) and after (in cost tab) link

bhanvimenghani commented 5 months ago

@kusumachalasani can u re-review the pr please.

kusumachalasani commented 5 months ago

here is the updated view of the ui with before (in perf tab) and after (in cost tab) link

@bhanvimenghani I'm unable to view the video. It says 'may have been deleted or archived by its creator.'

bhanvimenghani commented 5 months ago

https://www.loom.com/share/08fdf9c9ec094c56a1996c1a075411f4?sid=11d5c43e-429b-452c-911f-78aacb954a9f can u check if this one works

bhanvimenghani commented 5 months ago

image for testingquay.io/bmenghan/175

kusumachalasani commented 5 months ago

Couldn't test with the image because of 'Unable to Generate Recommendations' error in openshift.
To avoid these errors for the local monitoring demo for now - it would be good to use 'listRecomendations' API to view the recommendations.

bhanvimenghani commented 5 months ago

Couldn't test with the image because of 'Unable to Generate Recommendations' error in openshift. To avoid these errors for the local monitoring demo for now - it would be good to use 'listRecomendations' API to view the recommendations.

This change would be part of a different sprint, out of scope for this pr