Fixes lua build issue on latest source

krull / docker-janus

Debian based docker image for https://github.com/meetecho/janus-gateway

GNU General Public License v3.0

59 stars 49 forks source link

Fixes lua build issue on latest source #14

Closed bredfern closed 6 years ago

bredfern commented 6 years ago

I fixed the make build so that it excludes lua from the build. My eventual goal is to find a way to cleanly build lua so I can add this in as a configuration flag if you want lua or not. For now since lua fails to build for me on Ubuntu 16.04 I just hard coded an exclusion that works especially since most people are not using the new lua features yet.

randonia commented 6 years ago

It appears there are significant ∆s in here that are unrelated to the issue at hand.

Your bash dotfiles should be removed from this PR.
Did you accidentally change line endings?

Otherwise, the actual meat of your changes --disable-lua should probably be placed behind a configuration flag instead of hardcoding the disable.

bredfern commented 6 years ago

Yeah there's also an issue with use on Ubuntu where it's trying to use the system /var I'm going to need to run some diffs and do a better job explaining that fix then I need to put lua behind a flag hard coding is not good, you can reject this request and I'm going to diff my changes so I have a comprehensive list of what was changed and what it fixed so you have a much better quality pull request than this one.