krumsieklab / maplet

R statistical toolbox for metabolomics
GNU General Public License v3.0
17 stars 6 forks source link

Boxplot performance issues #119

Closed KelseyChetnik closed 3 years ago

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Jul 10, 2020, 11:53

Generating boxplots in mt_plots_boxplot and outputting them in mt_reporting_html takes way longer than it should, e.g. for 50-100 boxplots. Issue probably occurs when splitting into multiple pages. https://gitlab.com/krumsieklab/mt/-/blob/master/MetaboTools/R/mt_plots_boxplot.R#L191

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Jul 26, 2020, 14:50

Solution:

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Jul 28, 2020, 15:22

jitter is already a parameter, see lines 174-177 of mt_plots_boxplot.R

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Jul 28, 2020, 15:26

to facet wrap: gg + facet_wrap(~var, scales="free_y", ncol = 4)

KelseyChetnik commented 3 years ago

In GitLab by @elibene on Jul 28, 2020, 20:06

I would still add the option of using geom_jitter instead of geom_beeswarm, because it's much faster.

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Jul 28, 2020, 20:07

Yes, agreed. We will have all three variants, jitter, beeswarm, or none.

KelseyChetnik commented 3 years ago

In GitLab by @krumsiek on Oct 6, 2020, 15:40

This is now a duplicate with https://gitlab.com/krumsieklab/mt/-/issues/113