search

krunal09 / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Double elements appears in the main ui after editing options #930

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.install csipsimple from nightly build
2.add an account, set the options menu in expert mode, edit some settings and 
in particular make the screen rotating by orientation.
3.When back to the main phone UI, some elements ( the top and bottom buttons 
bars ) are "double"

What version of the product are you using? On what operating system?
revision 830 ( latest nightly build or self compiled ), on android 2.1 (toshiba 
folio 100 tablet )

Original issue reported on code.google.com by antanisa...@gmail.com on 6 May 2011 at 9:37

GoogleCodeExporter commented 9 years ago 
In fact this is a feature for tablets I've recently added.

I guess there is no contacts in your tablet (or toshiba did strange things with 
the contact app ;) ).
If you have contacts, in addition to the left part you should have all your 
contacts with phone numbers (or sip addresses).
In fact the right part is the digit dialer and the left part is text/contact 
dialer.
If you are on a smartphone the switch between digit and text dialer is a button 
on the left of the top textfield.
On tablet, since screen is bigger the two panels can be displayed side to side.

At least on my Acer Iconia it renders better.

However I had doubts about the large screen (iconia is xlarge). Maybe folio is 
only large and it does not render as well. If not, let me know, that's really 
easy for me to disable this feature for one screen size.

Also I'm wondering if this feature of dual pane should not appear only when in 
landscape mode... but this would be a little bit longer to implement ;).

Original comment by r3gis...@gmail.com on 7 May 2011 at 8:20

GoogleCodeExporter commented 9 years ago 
Well, after all was not so hard to distinguish landscape and portrait mode and 
apply dual pane only for landscape mode.

If it does not render well on folio, let me know, I'll exclude large screen 
from the "tablet" category that allow this dual pane mode. (if you can send me 
a screenshot could be cool too ;) ).

Original comment by r3gis...@gmail.com on 7 May 2011 at 8:54

GoogleCodeExporter commented 9 years ago 
Hello, you right, no matter the orientation, the issue there is in any case.

I've tryed to add an entry to my contacts, but nothing different, the issue is 
the same.

Attached two screenshot showing the problem

Original comment by antanisa...@gmail.com on 7 May 2011 at 8:08

Attachments:

GoogleCodeExporter commented 9 years ago 
Huh OK, that's absolutely not expected :-) 

You're absolutely right. I'll fix that right now. I forgot to add the side by 
side layout for large (I did only for xlarge). I'm even lucky that it does not 
crash ;-) 
Thanks for reporting

Original comment by r3gis...@gmail.com on 7 May 2011 at 9:40

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r836.

Original comment by r3gis...@gmail.com on 7 May 2011 at 9:46