krunal09 / sample

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Enable regular-expression based phone number modification when selecting to dial via SIP #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enable Android Dialer integration
2. Attempt to call a contact with an "incorrectly" (see below) formatted number 
via SIP

What is the expected output? What do you see instead?
The PBX dialing sequence fails because the number isn't properly formatted in 
order to complete the call.

Some PBX's require leading digits or codes to be added to a number prior to 
dialing out (i.e. 9...).  These aren't required for regular calls (normally, at 
least) and as such the numbers stored in the contact list don't contain them.

Thus, when attempting to call via SIP, there should be a way to tell CSipSimple 
to transform the number and bring it to the correct format for calling via the 
PBX, possibly specified by regular expression transformation.

Also, some local numbers are stored without any area codes or whatnot.  Such a 
mechanism could be used to add that information when missing - which would 
likely also be required by the PBX in order to successfully complete the call.

Ideally, one would be able to specify multiple regular expression 
transformations which would each be applied in order, succeeding or failing 
based on whether the number matches each pattern.

What version of the product are you using? On what operating system?
Version 0.00-11, on a Nexus One (AT&T), Android 2.1-update1 (Eclair)

Original issue reported on code.google.com by goatbo...@gmail.com on 22 Jun 2010 at 2:47

GoogleCodeExporter commented 9 years ago
Ok was evoked on the issue #41.
I'll try to add it as soon as possible.

Thanks for the suggestion. Besides your description add a really interesting 
use case that i'll take into account.

Original comment by r3gis...@gmail.com on 22 Jun 2010 at 7:10