kruschid / typesafe-routes

Spices up your favorite routing library by adding type safety to plain string-based route definitions.
https://kruschid.github.io/typesafe-routes/
MIT License
102 stars 8 forks source link

PeerDependency #41

Closed Xample closed 10 months ago

Xample commented 10 months ago

Hello, after installing the lib (npm i typesafe-routes) I got the following warning:

npm WARN Could not resolve dependency: npm WARN peer typescript@"^4.1.0" from typesafe-routes@10.0.5 npm WARN node_modules/typesafe-routes npm WARN typesafe-routes@"" from the root project npm WARN npm WARN Conflicting peer dependency: typescript@4.9.5 npm WARN node_modules/typescript npm WARN peer typescript@"^4.1.0" from typesafe-routes@10.0.5 npm WARN node_modules/typesafe-routes npm WARN typesafe-routes@"" from the root project

This is likely because I'm using typescript 5.x.x and your dependence peerDependencies are:

https://github.com/kruschid/typesafe-routes/blob/master/package.json#L36

  "peerDependencies": {
    "typescript": "^4.1.0"
  },

you should replace with:

"peerDependencies": {
  "typescript": ">=4.1.0"
},

i.e. any typescript version above or equals to 4.1

kruschid commented 10 months ago

Thank you for reporting @Xample

Please try v10.0.6 and let me know if you encounter any problems.

Xample commented 10 months ago

It works, thank you