Balls in Play Result - Githubissues

patrickjmcd commented 10 years ago

Especially from a pitcher's perspective, it would be great to either be able to filter the Balls in Play chart by result (Out vs. Safe). Going a step further, if the batter was safe, what was the result?

I know this has the potential to make the chart very messy, but maybe the Balls in Play chart could have a link to pop out to a chart with filters?

kruser commented 10 years ago

A picker in the title to swap?

screen shot 2014-03-07 at 4 08 48 pm

kruser commented 10 years ago

By the way, those screenshots above are just mockups - not real. I just put them in for discussion.

patrickjmcd commented 10 years ago

Yes! That's exactly what I was thinking.

kruser commented 10 years ago

I'd be fine with this then. Marking it as an enhancement. If anybody wants to start it let me know.

patrickjmcd commented 10 years ago

I'll give it a shot, but I'm still learning the nuts and bolts of how the site is put together. Might take me a bit.

albertlyu commented 10 years ago

@kruser, do you think we could start a general thread in https://github.com/kruser/atbat-mongodb/ with the purpose of helping new developers get set up who have specific questions? Or is there a better practice in Github project collaboration?

kruser commented 10 years ago

Sounds good @patrickjmcd, my email and twitter are on the homepage if you need to contact me or Albert while you're getting setup.

Note that the stats.js controller only returns an array of x/y coords keyed by trajectory. So there is server work here too. https://github.com/kruser/pitchfx-site/blob/master/app/lib/controllers/apis/stats.js#L137-L166

Switching views can either hit a new endpoint on the server, or you can just alter the stats function to return a better payload. Just take care not to increase the payload substantially.

kruser commented 10 years ago

@albertlyu, yeah, that's probably a good idea. Let me know where the doc isn't sufficient either. Installing Perl modules can sometimes be a bear.

patrickjmcd commented 10 years ago

Sorry that I've been absent for so long on this. I have the site up and running locally and I've been working to break it down to figure out how to make this happen (I'm still very new to AngularJS). I'll keep you all posted on my progress.

albertlyu commented 10 years ago

@patrickjmcd, good to hear from ya! I'm still very new to AngularJS as well. I've found ng-newsletter.com to be very useful as well as the many tutorials out there. I also had the benefit of attending an AngularJS workshop here in Chicago. But once you get the gist of the MVC framework, I think a great way to learn is to find an issue to contribute to here, then pick @kruser's brain. That's worked well for me thus far.

albertlyu commented 10 years ago

Also great that you were able to get the site up and running! Seems like the documentation works well, even for Windows users, as I was able to follow it beforehand too. Let's keep in mind of future developers who may need help setting up.

patrickjmcd commented 10 years ago

Worked just fine for me and I'm on a Mac.

Documentation was a huge help. — Sent from Mailbox for iPhone

On Wed, Apr 16, 2014 at 5:04 PM, Albert Lyu notifications@github.com wrote:

Also great that you were able to get the site up and running! Seems like the documentation works well, even for Windows users, as I was able to follow it beforehand too. Let's keep in mind of future developers who may need help setting up.

Reply to this email directly or view it on GitHub: https://github.com/kruser/pitchfx-site/issues/47#issuecomment-40658323

kruser / pitchfx-site

Balls in Play Result #47

Also great that you were able to get the site up and running! Seems like the documentation works well, even for Windows users, as I was able to follow it beforehand too. Let's keep in mind of future developers who may need help setting up.