krusty-is-cool / Covid-Dashboard

A simple dashboard
0 stars 1 forks source link

Bug: ECDC's data has changed #14

Closed raymas closed 3 years ago

raymas commented 3 years ago

The first dataset is now broken: no plot are displayed

Current behavior

This last step produces an error about undefined cases variable :

Uncaught TypeError: cases is undefined
    updateNumbers https://www.coviddash.app/static-dashboard.js:423
    plotGraph https://www.coviddash.app/static-dashboard.js:844
    <anonymous> https://www.coviddash.app/static-dashboard.js:84
    send https://cdn.plot.ly/plotly-latest.min.js:20
    n https://cdn.plot.ly/plotly-latest.min.js:20
    f https://cdn.plot.ly/plotly-latest.min.js:20
static-dashboard.js:423:9

Workaround

Commit 6aed3ac491af18b0af81a5b1ca2929d252cc5e45 add a banner for this issue.

Causes

As explained by the above commit:

The ecdc daily number of new cases reported has shifted to a weekly data collection since the 14th of decembre (source).

The downloadable data file contains information on the 14-day notification rate of newly reported COVID-19 cases per 100 000 population and the 14-day notification rate of reported deaths per million population by week and country. Each row contains the corresponding data for a certain day and per country. The file is updated weekly. You may use the data in line with ECDC’s copyright policy.

Possible solution

Delete the ecdc choice from the dashboard.

raymas commented 3 years ago

@krusty-is-cool what are your plans on this?

krusty-is-cool commented 3 years ago

Thank you @raymas for openning this issue.

As you saw, I quickly added an alert banner to inform user. This is highly temporary.

Step 1

Step 2

Step 3

krusty-is-cool commented 3 years ago

Commit d2ff24518dbb78a4cc76e399320091586f6534f6 accomplishes Step 1 of fix.