onerror and onload on script tags not firing

krux / postscribe

Asynchronously write javascript, even with document.write.

MIT License

986 stars 157 forks source link

onerror and onload on script tags not firing #262

Closed zaffudo closed 8 years ago

zaffudo commented 8 years ago

The issue described in https://github.com/krux/postscribe/issues/132 does not appear to be fixed in version 2.0.6. onload and onerrorevents do not appear to be firing on scripts written via Postscribe.

The simple test case found below fails to execute the documentDone function: https://github.com/krux/postscribe/pull/133/commits/df34363fabfdc3fa3124dc78fdc373a82dea6148

sethyates commented 8 years ago

@zaffudo I have some changes here https://github.com/krux/postscribe/pull/312 which fix this in unit test. could you check that branch out and let me know if it works for you?