search

krux / postscribe

Asynchronously write javascript, even with document.write.
MIT License
986 stars 157 forks source link

Null pointer error fired on aborting postscribe execution #306

Closed OleksandrShatylo closed 8 years ago

OleksandrShatylo commented 8 years ago

When postscribe(null, null, "clear"); is called it seems to continue using active stream writer which is null. This leads to several null pointer exceptions.

sethyates commented 8 years ago

hi @OleksandrShatylo,

I can't reproduce this. I've added a unit test to this branch: https://github.com/krux/postscribe/tree/fix/issue-306. However, either I'm not understanding your problem or the code works. If you can reproduce, please update that unit test and file a pull request.

sethyates commented 8 years ago

Here's a link directly to the unit test: https://github.com/krux/postscribe/blob/fix/issue-306/test/bugs/issue306.spec.js

sethyates commented 8 years ago

Closing due to lack of a failing unit test.

jnewman commented 7 years ago

Removed the unit test branch as it's been a month and we don't seem to want that on master.