make email notification settings configurable

krux / starport

Apache License 2.0

2 stars 7 forks source link

make email notification settings configurable #18

Closed talbright closed 5 years ago

talbright commented 5 years ago

Addresses #17

talbright commented 5 years ago

Do we care about this logic:

pipeline.owner.getOrElse(PagerDutyEmail)

Meaning, should I appended that to the toEmails sequence? I tend to think we can dump this. If we do need to include it, you want there to be a new variable to use as the default, something like krux.starport.notification.email.defaultOwner?

realstraw commented 5 years ago

LGTM, let's update the version to 5.1.0