search

krux / starport

Apache License 2.0
2 stars 7 forks source link

[W-6873353] Add CloudWatch metrics engine #52

Closed jkbudd closed 4 years ago

jkbudd commented 4 years ago

This PR turns the MetricSettings object into a sealed trait, which is then inherited by the case objects GraphiteReporterSettings and CloudWatchReporterSettings. The selection of the reporting engine is controlled via the metricsEngine key in StarportSettings.

jkbudd commented 4 years ago

@sushengloong This is ready for another look now.

@talbright This can now handle an arbitrary number of dimensions coming in from the conf file.

cc: @realstraw

jkbudd commented 4 years ago

@talbright, @realstraw This now has a new object called DefaultConsoleReporterSettings which Starport will default to if metrics.engine is null or if the config for Graphite or Cloudwatch is missing.