krv5vignesh / Dictionary-extension

Firefox WebExtension - English Popup Dictionary
https://addons.mozilla.org/en-US/firefox/addon/english-popup-dictionary/
GNU General Public License v3.0
43 stars 11 forks source link

Not working in any of my browsers #27

Closed vayulove closed 5 years ago

vayulove commented 5 years ago

I've had this installed and working in several browsers for a long time. recently it has stopped working. When I double click a word the popup still displays but it says "No definition found".

I have several versions of Firefox installed all with separate profiles and I get the same "No definition found" on every one of them. Any ideas what could be happening?

weird-o commented 5 years ago

I'm having the same problem, so it's not just you. I tried removing and reinstalling the extension, but that didn't help.

vayulove commented 5 years ago

Thanks, always nice to know you're not alone. I also did the same uninstall and reinstall. I even installed it fresh on a Firefox that didn't have it previously installed. I was thinking maybe the dictionary is kept online somewhere and that it's down or something.

krv5vignesh commented 5 years ago

Thanks for bringing this to my notice. Didn't know there was an issue. I'll look at the issue and update here.

krv5vignesh commented 5 years ago

The API I was using was Wordnik API. They have recently decided to limit the no. of API calls I can make for free. As of Jan 31st, the no of calls I can make per hour is only 100. IIRC it was 1000 calls/hour. Anyway that is the issue.

I looked for other free APIs I can use, but couldn't find anything better so far. Yandex and Glosbe API were free but the definitions are not that good. So it'll take some time until I find an API. If you know some APIs please suggest.

ghost commented 5 years ago

maybe it can fit https://dictionaryapi.com/

Clover-Leaves commented 5 years ago

I just installed this (2/10/18) and got the same error. Did a little digging and got it to work by changing the Pop-Up Dictionary Settings to: http://www.wordreference.com/definition/$$

The key was the addition of /definition/ as shown above

vayulove commented 5 years ago

I just installed this (2/10/18) and got the same error. Did a little digging and got it to work by changing the Pop-Up Dictionary Settings to: http://www.wordreference.com/definition/$$

The key was the addition of /definition/ as shown above

Where did you add that? I don't see anything in the preferences that could be set to that.

Clover-Leaves commented 5 years ago

[cid:18857cdd-0bc3-4f33-b0e8-6b425e5c9906] It's late, so I'll have to keep this short..... In your browser, click your icon that is shown in the red circle...... Click "Settings" at the bottom of the PopUp. You should see the menu below.... [cid:2a0e1c17-bcda-4880-a7bd-e55a74f629b9] Click "Edit" The following appears.........

[cid:659cd4d4-affa-45d0-b7a5-f2041027bfb7] This is what I see on my computer.... Change the "/fren/" to "/definition/" as shown below

[cid:e87c91fb-6c12-4ef3-884e-cf2b8ec25853] Save it and try it out..... If you get this PopUp....... [cid:b3834e6e-02d5-4ed4-a6d5-54a39462fe67] Go here and follow the directions..... https://sites.google.com/site/helloricky432/home/howtodisablefirefoxmixedcontentblocking [https://sites.google.com/site/helloricky432/_/rsrc/1487346204669/home/howtodisablefirefoxmixedcontentblocking/Untitled.png]https://sites.google.com/site/helloricky432/home/howtodisablefirefoxmixedcontentblocking

How to disable Firefox mixed content blocking - Rhttps://sites.google.com/site/helloricky432/home/howtodisablefirefoxmixedcontentblocking sites.google.com

All should work as expected......it has worked on two of my computers so far......


From: Vayu notifications@github.com Sent: Sunday, February 10, 2019 10:45 PM To: krv5vignesh/Dictionary-extension Cc: Clover-Leaves; Comment Subject: Re: [krv5vignesh/Dictionary-extension] Not working in any of my browsers (#27)

I just installed this (2/10/18) and got the same error. Did a little digging and got it to work by changing the Pop-Up Dictionary Settings to: http://www.wordreference.com/definition/$$

The key was the addition of /definition/ as shown above

Where did you add that? I don't see anything in the preferences that could be set to that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/krv5vignesh/Dictionary-extension/issues/27#issuecomment-462212828, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AtT9R8rhtLGGneA8nz8AW5woxbXCL83_ks5vMOdPgaJpZM4afjhf.

krv5vignesh commented 5 years ago

The dictionary should work now. The API issue has been fixed.

blwol commented 5 years ago

It's not working for me. Every word I double-click on, results in a "No definition found".

vayulove commented 5 years ago

It worked for me when I checked last night after getting the email that it was fixed. But this morning it also isn't working for me.

krv5vignesh commented 5 years ago

Reopening this issue. I opted for a paid plan and it was working fine. Turns out with increase in number of users the paid plan also runs out after some time.

Will keep this issue open until I figure out a long-term solution.

koynoyno commented 5 years ago

Maybe it will be good to substitute Wordnik for another free API as workaround?

krv5vignesh commented 5 years ago

The issue has been fixed. Please update to version 1.8.1.

I will keep this issue open for a while.