search

kryptco / homebrew-tap

Other
6 stars 5 forks source link

changing ~/.ssh/config is a bad idea, sometimes this isn't managed manually #3

Closed cnf closed 7 years ago

cnf commented 7 years ago

I use assh which manages my ~/.ssh/config. There are other situations where the ssh_config isn't manually managed.

Editing the ssh_config without user consent at best doesn't work, and at worse breaks the users ssh setup.

Please don't do this... echo what to do or make a command to do it, but don't do this without asking for it.

jbgosselin commented 7 years ago

I totally agree, I love your product but I removed it just because I don't want re-do my ssh config every-time it is updated.

halostatue commented 7 years ago

This should be fixable with a post-message and/or a “build-time” option (--no-ssh-config) so that those of us who manage your SSH configurations can force reconfiguration based on the new settings (I have things set up to handle this correctly).

kcking commented 7 years ago

Sorry for the incompatibility with assh. As a stopgap fix, I added a --without-ssh-config option which will not run any commands to modify ~/.ssh/config and prints what should be added there in the caveats.

We might move ssh_config logic to kr pair and prompt the user then

kcking commented 7 years ago

Our latest update moves SSH configuration to the kr pair stage instead of installation time. This solves the issue of SSH not being configured for other usernames on the computer. We added an env var to prevent kr from touching your ssh config, export KR_SKIP_SSH_CONFIG=1. Note that the config file is always backed up in the same directory before we modify it.