search

kryptco / krypton-android

DEPRECATED Krypton turns your Android device into a U2F Authenticator: strong, unphishable 2FA.
https://krypt.co
Other
203 stars 50 forks source link

Posible to load custom appid.json #112

Closed DaveM2011 closed 5 years ago

DaveM2011 commented 5 years ago

It would be great if the app scanned the remote orign for a custom appid.json to display name and icon from within app rather than the origin and that ugly arrow icon

agrinman commented 5 years ago

Do you have an example of a site that has this in the trusted facets Json? What service is missing for you btw?

DaveM2011 commented 5 years ago

{"trustedFacets":[{"version":{"major":1,"minor":0},"ids":["https://origin.server"]}]} perhaps just see if https://origin.server/u2fappid.json exists and if so use data from within that or just scan for an https://origin.server/u2fappid_icon.(ico|png) becasue currently only if its a known id from the list provided here https://github.com/kryptco/krypton-android/blob/master/app/src/main/java/co/krypt/krypton/u2f/KnownAppIds.java will it show an icon i hope that makes sense

agrinman commented 5 years ago

But do sites actually support icons there? I.e. does GitHub for example have any icon to download like in your example?

DaveM2011 commented 5 years ago

well the one on my dev site does but krypton does not load it as its not a known app id but i see the list here https://github.com/kryptco/krypton-android/blob/master/app/src/main/java/co/krypt/krypton/u2f/EtldProvider.java seems u have to be a real site i guess

agrinman commented 5 years ago

I don't think there's a standard in place for icons and such so we've just been adding known sites manually as you noted. This way the user knows where they are logging in.

Would be happy to look at a PR with your site's icon/name and trusted facet url when it's live! Closing this for now though.

DaveM2011 commented 5 years ago

OK thanks