search

kryptco / krypton-android

DEPRECATED Krypton turns your Android device into a U2F Authenticator: strong, unphishable 2FA.
https://krypt.co
Other
203 stars 50 forks source link

Thread and lock cleanup #64

Closed kennylevinsen closed 7 years ago

kennylevinsen commented 7 years ago

This PR cleans up thread and lock handling, primarily around Silo and pairings.

The purpose of this cleanup is to improve code clarity, and reduce chances of multi-threaded surprises, as more code is under natural synchronization of the UI thread.

I'd recommend checking the individual commits, rather than the full PR. They're all self-contained. There are a few minor cleanup commits in there as well. They're all changes with a purpose, despite how tempted I have been to fix everything Android Studio has to say...

Have a look, see what you think.

kennylevinsen commented 7 years ago

(Tell me if you want me to split up the PR)

kcking commented 7 years ago

LGTM! I'm just rebasing locally to squash the related commits

kcking commented 7 years ago

(merged manually)