search

kryskool / cefpython

Automatically exported from code.google.com/p/cefpython
0 stars 1 forks source link

chromectrl: a new timer for message loop processing is created for each ChromeWindow instance #129

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There should be only one global timer running. In the wxpython.py example the 
timer is created and destroyed in wx.App. But in chromectrl it is created for 
each chrome window. Creating multiple timers that call CefMessageLoopWork 
simultaneously might result in performance penalties and an undefined behavior.

Original issue reported on code.google.com by czarek.t...@gmail.com on 30 Jul 2014 at 8:11

GoogleCodeExporter commented 9 years ago 
Chromectrl creates a timer with given ID. Does calling wx.Timer() multiple 
times given the same ID result only in one timer running? The timer ID is 
currently = 1. What if other part of app assigns the same id? Should it be 
unique?

Original comment by czarek.t...@gmail.com on 30 Jul 2014 at 8:24

GoogleCodeExporter commented 9 years ago 
Answering question from the post above. The timer is associated with "self" 
which is ChromeWindow, so the ID uniqueness is not a problem. But still it 
creates multiple timers for multiple ChromeWindow instances.

Original comment by czarek.t...@gmail.com on 30 Jul 2014 at 8:27

GoogleCodeExporter commented 9 years ago 
Fixed in revision e592db916887.

Original comment by czarek.t...@gmail.com on 30 Jul 2014 at 9:44