search

krystal / terraform-provider-katapult

Terraform Provider for Katapult.
https://registry.terraform.io/providers/krystal/katapult/latest/docs
MIT License
5 stars 2 forks source link

Use retryablehttp client #27

Closed jimeh closed 3 years ago

jimeh commented 3 years ago

Use retryablehttp to make HTTP requests against the Katapult Core API. It's potentially not needed, but should help ensure the provider is more reliable in the event of any network glitches or the like.

jimeh commented 3 years ago

Closed in favor of supporting retryablehttp in the Katapult API client library: https://github.com/krystal/go-katapult/issues/60

jimeh commented 3 years ago

Ignore my previous comment closing this issue, I've changed my mind after thinking about implications it would have for the client library. So I'm favoring keeping the client library simple, and having the terraform provider configure retryablehttp for it's purposes and passing in a custom *http.Client to the *katapult.Client.

PR is #32.

jimeh commented 3 years ago

Resolved by #32.