kryx7
commented
7 years ago Thank you very much for the helpful comments. I knew the code has lots of improvement opportunities, therefore I am grateful for the specific, on point feedback you've provided. I will keep it in mind the next time I take up such challenge. :)
Summary Grade: Satisfactory
Good Job! Your files are organized, your code is well structured, and you did a good job at following the client specification and making your site super user friendly. Moreover, your code is generally simple, clean and easy to follow overall so definitely make sure to keep that up!
I have made a few comments about your code. Good job commenting parts of your HTML, which is something that many learners forget to do. An area of improvement is to make sure to comment your CSS further so its absolutely clear what is happening at each section of your code -- this will become increasingly important as your projects get larger and more complex. Here is a quick reminder on commenting in CSS:
I also noticed that your HTML can be quite inconsistent in terms of indentation and formatting in general and so here is a great resource that goes over how to properly indent and format your code:
https://www.granneman.com/webdev/coding/formatting-and-indenting-your-html/
It also seems that your site is not fully responsive -- when I decrease the browser width, the contents on the page do not seem to respond accordingly so I would look into that and make sure your page is responsive depending on the browser size.
As a further challenge, see if you can incorporate a dropdown menu system in your website! This can be tricky and may require outside research for you to understand, but it is certainly a cool feature to have. I would recommend this resource to get you started:
https://www.w3schools.com/css/css_dropdowns.asp