krzema12 / kotlin-python

Python target for the Kotlin Programming Language. See https://github.com/krzema12/kotlin-python/tree/python-backend/python
https://discuss.kotlinlang.org/t/idea-python-backend/19852
48 stars 1 forks source link

Fix some name clashes #28

Closed SerVB closed 3 years ago

SerVB commented 3 years ago

Here I cherry pick 2c1f176 and add suffixes to more places of name clashes.

Some more tests pass now. There are two regressions also:

Multiplatform$DefaultArguments > testBothInExpectAndActual2 FAILED
Properties > testTwoAnnotatedExtensionPropertiesWithoutBackingFields FAILED

I've checked them manually, it seems they passed before because of functions were clashed and improper ones were called. They fail now because the correct functions are called, but there are default arguments and extension function that we don't support yet.

So I suppose these regressions are OK.

There can be still clashes, need to inspect other places more carefully in the future. Also, suffixes are looking quite ugly, maybe we can invest some time in making them prettier.

Let's firstly deal with #27 and then with this PR. [v] Done.