Closed SerVB closed 2 years ago
@SerVB no problem, we can make the normalizing logic more generic. The @
sign that stands before the random part is itself pretty rare, so I'm not too afraid of some eager normalizations of places that shouldn't be normalized. Feel free to adjust as you suggest.
Hey @krzema12, I see my testing was failing because a varying part wasn't removed:
Do you think we can change
@[a-f0-9]{7,8}
to@[a-f0-9]{1,8}
in the remover? I'm asking because you are the author of these lines and maybe there is a reason why you've decided to use{7,8}
only. Indeed hashes less than 7 symbols are rare, but they can happen...https://github.com/krzema12/kotlin-python/blob/80650cb95b8cd972e1c7e60f5a7cd7fae1bfdd13/python/experiments/generate-box-tests-reports.main.kts#L114
I'm rebasing to master now anyway so this rare problem will likely go away, but it can happen in the future.