Closed SerVB closed 3 years ago
Github says "This branch cannot be rebased due to conflicts". Could you take a look?
Yeah, I guess it's because it contains a merge commit, so GH can't rebase it. Don't you mind if we just merge this PR? "Create a merge commit" button is available for me even in this PR.
By the way, sorry for early ping – let's wait until the CI finishes. I will add you to reviewers once again after that.
Sure, I didn't mean to dig to deep into this PR, all I wanted to check is the number of passing box tests - if we don't have any regression :)
all I wanted to check is the number of passing box tests - if we don't have any regression
It's hard to say. The numbers of both passing and total tests are now bigger.
Well, the PR is quite big, but I've only made the last commit: I've fixed some compilation problems, picked changes from JS module, and updated some info. Maybe you even don't want to review it (but I advice checking the updated README at least). The diff is still small because this PR doesn't include my changes to the IR transformer, I will update those PRs later.