search

krzema12 / kotlin-python

Python target for the Kotlin Programming Language. See https://github.com/krzema12/kotlin-python/tree/python-backend/python
https://discuss.kotlinlang.org/t/idea-python-backend/19852
47 stars 1 forks source link

CI Reports #90

Closed SerVB closed 2 years ago

SerVB commented 2 years ago

This closes #83.

SerVB commented 2 years ago

Looks working, please be peaky as you said ;)

SerVB commented 2 years ago

Well, probably I should have tested it by deleting all the autogenerated files in a separate branch and checking that all are generated.

I can do it the next week. Or if you want to do it, I don't mind :)

krzema12 commented 2 years ago

Well, probably I should have tested it by deleting all the autogenerated files in a separate branch and checking that all are generated.

I can do it the next week. Or if you want to do it, I don't mind :)

+1, It would be cool if you could test it :)

krzema12 commented 2 years ago

Could you also update our README? The procedure before sending a PR and maybe other things.

krzema12 commented 2 years ago

You wrote on Slack:

I think I'll continue to generate reports for plain Python locally, but for MicroPython, CI will do it.

Do I see correctly that after this change, reports are generated by CI for both types of Python? FTR, it's better for me because it's more consistent :)

SerVB commented 2 years ago

Do I see correctly that after this change, reports are generated by CI for both types of Python? FTR, it's better for me because it's more consistent :)

Yeah, the CI generates both reports. And if I generate and commit only a single type locally, the CI will update the remaining one.

SerVB commented 2 years ago

Well, I think now it's ready. Looks like workflow_dispatch actions can't be triggered until they are in the default branch. So I've created a fork and checked there: https://github.com/SerVB-s/kotlin-python/actions.

Feel free to be picky again. I will try to resolve all the major problems found.

I can rerequest the review once the checks are passed.