krzmig / strelloids

Browser extension for Trello that adds new features.
MIT License
34 stars 6 forks source link

[Bug] Auto Collapse Empty Lists not working #20

Closed Cassidy13K closed 3 years ago

Cassidy13K commented 3 years ago

Describe the bug The newest Strelloids Version added the Option "Auto collapse empty lists". Enabling this option throws an error in the browser console. It does not change the collapse status of any lists. Upon refreshing the page, the option is disabled again.

To Reproduce Steps to reproduce the behavior:

  1. Open the Strelloids Global settings
  2. Select "Lists collapsing" category
  3. open your browser console
  4. enable or disable the check box
  5. check your trello boards

Expected behavior Expected all empty lists to be collapsed & the status of the option be saved upon page refresh.

Screenshots If applicable, add screenshots to help explain your problem. image

Browser details

Additional context The error says something about quote exceeded. Perhaps the addon tries to collapse to many lists at once? It's unclear to me whether it will only collapse the ones on boards that are currently open in any browser tab, or if all the user is a member of. Especially if it's the last case the addon might be trying to collapse thousands of lists at the same time, since many users are part of big boards. Closing all open tabs with trello boards did not fix the issue.

krzmig commented 3 years ago

Hello, I cannot reproduce your issue, but I found that Mozilla changed limitations for storage.sync (share addons data between all your connected browsers) starting from Firefox 79. Bug in console is unclear which limit has been exceeded.

Can you run these command in developer console (from options page as in screenshot) and send result:

First will return size of your saved data and second one will return number of items saved on storage.

Thanks for report :)

Cassidy13K commented 3 years ago

Good afternoon, Thank you for your swift reply and the new version. Please see the picture below for the results you requested:

image

For good measures, I have disabled all other addon except for Strelloids and ran the same commands, resulting in the exact same numbers. I'm logged in on a Firefox Account that is synced to my mobile device - which is currently not in use. Please let me know if there is any other information or help I can provide to make this very helpful feature work. Cheers :)

krzmig commented 3 years ago

Problem is both, amount of items and them size. I will try move lists settings from sync storage, to local, and keep global and boards settings in sync storage. I think that should fix your problem.

krzmig commented 3 years ago

Ok, I moved settings of lists into local storage.

Can you download zip from below link and check is that will fix your problem? https://github.com/krzmig/strelloids/releases/tag/v2020.9.27-beta

After download:

You can also run commands from the previous post and paste the results.

Cassidy13K commented 3 years ago

It seems to have worked. 👍 🎉 The checkbox stays enabled upon refresh and lists get automatically collapsed. Please see the picture for the command results:

image

krzmig commented 3 years ago

Good to hear. I will upload new version to the market. Many thanks for the report and help :)