search

krzysiekpiasecki / Gentelella

Welcome to Gentelella - Responsive Bootstrap Admin Application based on the Foundation of Symfony and Gentelella!
http://gentelella.herokuapp.com
MIT License
100 stars 54 forks source link

composer.json file to be used under windows #32

Closed MedUnes closed 7 years ago

MedUnes commented 7 years ago

changed: "./vendor/bin/phing build " to "vendor\bin\phing build "

krzysiekpiasecki commented 7 years ago

This PR has broken installation on OS where the directory separator is /.

The way to handle is making installation OS sensible via custom script or using composer exec command.

May I ask you to replace vendor\bin\phing build with composer exec phing build and test it on WIN as a clean install?

MedUnes commented 7 years ago

I added it as a composer.json.win and not composer.json So just mention: "Under Windows OS change the file extension and use it for composer installation" A solution that works at least, IMHO.

krzysiekpiasecki commented 7 years ago

Now, I see your point. It should work well, but there is no need to have two composer files for executing build process after vendor installation.

The solution with composer exec command should be a cross compatible, but let me do not close your PR.

krzysiekpiasecki commented 7 years ago

At the end two composer files is not a convention. So I'm closing this ticket.

It's related to #53

@MedUnes thanks for the contribution.