search

krzysiekpiasecki / Gentelella

Welcome to Gentelella - Responsive Bootstrap Admin Application based on the Foundation of Symfony and Gentelella!
http://gentelella.herokuapp.com
MIT License
100 stars 54 forks source link

(CI) php-cs-fixer must return non-zero value when no CS #55

Closed krzysiekpiasecki closed 7 years ago

krzysiekpiasecki commented 7 years ago

PHP-CS-FIXER must return non-zero value: https://travis-ci.org/krzysiekpiasecki/Gentelella/jobs/241787978

MedUnes commented 7 years ago

The command "./vendor/bin/phpunit" exited with 0.

As I know, this means the build passes and no errors were found in analyzed code. Could you explain please?

krzysiekpiasecki commented 7 years ago

Before pushing use php ./vendor/bin/php-cs-fixer command. The configuration file is at the root.

This project follows Symfony coding standards using fixer https://github.com/FriendsOfPHP/PHP-CS-Fixer

When source code is not properly formated CI must stop. I don't know if Travis CI can push back fixed source code to the github repo.

MedUnes commented 7 years ago

I think it is fixed right now.

krzysiekpiasecki commented 7 years ago

@MedUnes fixed now with https://github.com/krzysiekpiasecki/Gentelella/commit/237994d13a0e80c056255be5376d2138567eedd7

Test https://travis-ci.org/krzysiekpiasecki/Gentelella/jobs/242332520