search

krzysu / flot.tooltip

tooltip plugin for wonderful Flot plotting library
https://github.com/krzysu/flot.tooltip
187 stars 153 forks source link

Remove Tooltip element from DOM on shutdown #132

Closed Botffy closed 9 years ago

Botffy commented 9 years ago

Not removing the tooltip in the shutdown hook is normally not a big deal, but creates issues in single-page applications: if the user navigates away while a tooltip is displayed, the tooltip stays visible on the page until a hard reload, and that's really awkward.

Roundaround commented 9 years ago

This is a great addition, and I know I'm being picky, but the removeTooltip function declaration needs to be ended with a semicolon. Add that in and I'd be happy to merge this for you.

Botffy commented 9 years ago

All fixed! Sorry about it :blush: